Code review comment for lp:~chipaca/ubuntuone-client/public_files_list_v2

Revision history for this message
dobey (dobey) wrote :

I'd prefer to not have the additional got_one_public file function here, and just use a for loop instead. Is there any particular reason not to do so?

I'd also really like to know why exactly GSList wouldn't work for the signal here. We're using a GSList of GHashTables elsewhere for "aa{ss}" signatures from DBus, just fine. So, I'd like to understand why exactly it's failing here, but not elsewhere, and why a GPtrArray would work instead. It makes no sense to me at all.

« Back to merge proposal