Code review comment for lp:~chipaca/ubuntuone-client/devices-tab

Revision history for this message
dobey (dobey) wrote :

Can we get rid of the '<b>Name</b>' label and row? I think it's a waste; it's oddly positioned, and looks weird.

The _Connect and _Disconnect labels still conflict with other mnemonics in the dialog. Please get rid of the _ in the strings, or change them to be _o in both strings (so that it doesn't change mnemonics).

You didn't add any more logger.error() calls. Please use logger.error() to log the errors you trap from DBus or elsewhere.

And I still thoroughly disagree with the "The devices blah blah" label. :)

review: Needs Fixing

« Back to merge proposal