86 + self.status_label = gtk.Label("Please wait...")
87 + self.attach(self.status_label, 0, 3, 2, 3)
88 +
89 + self.description = gtk.Label("The devices connected to with your personal cloud network are listed below")
90 + self.description.set_alignment(0., .5)
91 + self.description.set_line_wrap(True)
92 + self.attach(self.description, 0, 3, 0, 1, xpadding=12, ypadding=12)
These need to be translated if they're going to be in here. However, I'd prefer to just remove them. "Please wait" should very rarely, if ever, be seen, and "The devices..." is redundant and made obvious by the contents of the tab.
245 + response = response.read() # neither shouold this
Typo.
303 + butn = gtk.Button('Remove')
Needs to be marked for translation.
330 + self.conn_btn = gtk.Button(_('_Connect'))
This creates a mnemonic key which conflicts with the _Close button of the dialog. I think we should perhaps avoid having mnemonics on the Connect/Disconnect and Restart buttons. But we should probably set them to _U and _D for the Upload/Download labels for the spin buttons (and hook the mnemonics to the widgets), as was previously done...
86 + self.status_label = gtk.Label("Please wait...") self.status_ label, 0, 3, 2, 3) n.set_alignment (0., .5) n.set_line_ wrap(True) self.descriptio n, 0, 3, 0, 1, xpadding=12, ypadding=12)
87 + self.attach(
88 +
89 + self.description = gtk.Label("The devices connected to with your personal cloud network are listed below")
90 + self.descriptio
91 + self.descriptio
92 + self.attach(
These need to be translated if they're going to be in here. However, I'd prefer to just remove them. "Please wait" should very rarely, if ever, be seen, and "The devices..." is redundant and made obvious by the contents of the tab.
245 + response = response.read() # neither shouold this
Typo.
303 + butn = gtk.Button( 'Remove' )
Needs to be marked for translation.
330 + self.conn_btn = gtk.Button( _('_Connect' ))
This creates a mnemonic key which conflicts with the _Close button of the dialog. I think we should perhaps avoid having mnemonics on the Connect/Disconnect and Restart buttons. But we should probably set them to _U and _D for the Upload/Download labels for the spin buttons (and hook the mnemonics to the widgets), as was previously done...
581 - label = gtk.Label( _("Maximum _upload speed (KB/s):")) _("Maximum _download speed (KB/s):")) _("Download (kB/s):"))
596 - label = gtk.Label(
311 + up_lbl = gtk.Label(_("Upload (kB/s):"))
318 + dn_lbl = gtk.Label(
Any reason to change these labels from what they were previously? And to change from KB to kB? This breaks the existing translations.
Also, since you added logging in this branch, is there any reason you don't log the errors when they occur, but only stick them in a status label?