Ubuntu Push Notifications

Code review comment for lp:~chipaca/ubuntu-push/whoopsie-identifier

  1. whoopsie-identifier
  2. Merge into trunk
Revision history for this message
John Lenton (chipaca) wrote :

Good points, all of them.

> * two levels of dirs/packages in case this gets extracted into a real whoopsie package?

Are you asking whether that is why I made two levels? (yes). Are you suggesting I add a third level?

About checking interfaces, yes I forgot to do that. I thought you checked interfaces doing

    if ok := myObject.(myInterface); !ok {
        panic and dispair
    }

About SettableIdentifier, you think SettableIdentifier and FailingIdentifier should be exposed in production?

« Back to merge proposal