Merge lp:~chipaca/ubuntu-push/shawn into lp:ubuntu-push
Proposed by
John Lenton
Status: | Rejected |
---|---|
Rejected by: | John Lenton |
Proposed branch: | lp:~chipaca/ubuntu-push/shawn |
Merge into: | lp:ubuntu-push |
Prerequisite: | lp:~chipaca/ubuntu-push/client-session-getting-there |
Diff against target: |
96 lines (+30/-9) 2 files modified
client/session/session.go (+12/-3) client/session/session_test.go (+18/-6) |
To merge this branch: | bzr merge lp:~chipaca/ubuntu-push/shawn |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Lenton (community) | Disapprove | ||
Review via email: mp+204411@code.launchpad.net |
Commit message
Gave ClientSession a Shown method that the client can use to indicate when a notification has been displayed (and made Client Session only update the levelmap on Shown).
Description of the change
Gave ClientSession a Shown method that the client can use to indicate when a notification has been displayed (and made Client Session only update the levelmap on Shown).
To post a comment you must log in.
Unmerged revisions
- 43. By John Lenton
-
Gave ClientSession a Shown method that the client can use to indicate when a notification has been displayed (and made Client Session only update the levelmap on Shown)
After discussing this on IRC, I'll add Shown when I track shown vs. not shown in the session (the protocol-side ACK vs increasing levels is correct as it stands now).