Code review comment for lp:~chipaca/ubuntu-push/service

The attempt to merge lp:~chipaca/ubuntu-push/service into lp:ubuntu-push/automatic failed. Below is the output from the failed tests.

rm -f -r /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/pkg
mkdir -p /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin
mkdir -p /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/pkg
go get -u launchpad.net/godeps
go get -d -u launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3 launchpad.net/~ubuntu-push-hackers/ubuntu-push/go-uuid/uuid
/mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin/godeps -u dependencies.tsv
"/mnt/tarmac/cache/ubuntu-push-automatic/go-ws/src/launchpad.net/gocheck" now at <email address hidden>
go install launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3 launchpad.net/~ubuntu-push-hackers/ubuntu-push/go-uuid/uuid
go test launchpad.net/ubuntu-push launchpad.net/ubuntu-push/bus launchpad.net/ubuntu-push/bus/connectivity launchpad.net/ubuntu-push/bus/networkmanager launchpad.net/ubuntu-push/bus/notifications launchpad.net/ubuntu-push/bus/systemimage launchpad.net/ubuntu-push/bus/testing launchpad.net/ubuntu-push/bus/urldispatcher launchpad.net/ubuntu-push/client launchpad.net/ubuntu-push/client/gethosts launchpad.net/ubuntu-push/client/service launchpad.net/ubuntu-push/client/session launchpad.net/ubuntu-push/client/session/levelmap launchpad.net/ubuntu-push/config launchpad.net/ubuntu-push/external/murmur3 launchpad.net/ubuntu-push/logger launchpad.net/ubuntu-push/protocol launchpad.net/ubuntu-push/server launchpad.net/ubuntu-push/server/api launchpad.net/ubuntu-push/server/broker launchpad.net/ubuntu-push/server/broker/simple launchpad.net/ubuntu-push/server/broker/testing launchpad.net/ubuntu-push/server/broker/testsuite launchpad.net/ubuntu-push/server/dev launchpad.net/ubuntu-push/server/listener launchpad.net/ubuntu-push/server/session launchpad.net/ubuntu-push/server/store launchpad.net/ubuntu-push/testing launchpad.net/ubuntu-push/testing/condition launchpad.net/ubuntu-push/util launchpad.net/ubuntu-push/whoopsie launchpad.net/ubuntu-push/whoopsie/identifier launchpad.net/ubuntu-push/whoopsie/identifier/testing
? launchpad.net/ubuntu-push [no test files]
ok launchpad.net/ubuntu-push/bus 0.008s
ok launchpad.net/ubuntu-push/bus/connectivity 1.161s
ok launchpad.net/ubuntu-push/bus/networkmanager 0.097s
ok launchpad.net/ubuntu-push/bus/notifications 0.017s
ok launchpad.net/ubuntu-push/bus/systemimage 0.006s
ok launchpad.net/ubuntu-push/bus/testing 0.030s
ok launchpad.net/ubuntu-push/bus/urldispatcher 0.008s

----------------------------------------------------------------------
FAIL: client_test.go:291: clientSuite.TestStartServiceWorks

client_test.go:297:
    c.Check(cli.service.IsRunning(), Equals, true)
... obtained bool = false
... expected bool = true

2014/05/14 10:28:26.701116 INFO Sending initial 'disconnected'.
2014/05/14 10:28:26.701507 DEBUG Invoking Info
2014/05/14 10:28:26.701693 DEBUG got initial state of Connected Global
2014/05/14 10:28:26.701718 ERROR got weird PrimaryConnection: 0x46
2014/05/14 10:28:26.701725 DEBUG primary connection starts as ""
2014/05/14 10:28:26.701741 DEBUG got state: Connected Global
2014/05/14 10:28:26.701761 ERROR got weird PropertiesChanged: 0x46
2014/05/14 10:28:26.701772 DEBUG State changed to Connected Global. Assuming disconnect.
2014/05/14 10:28:26.701827 DEBUG May be connected; checking...
2014/05/14 10:28:26.702535 INFO Connectivity check passed.
2014/05/14 10:28:26.702609 DEBUG Connection check says: true
2014/05/14 10:28:26.702630 INFO Sending 'connected'.

----------------------------------------------------------------------
FAIL: client.go:1: sqlientSuite.TestStartServiceWorks

client_test.go:297:
    c.Check(cli.service.IsRunning(), Equals, true)
... obtained bool = false
... expected bool = true

2014/05/14 10:28:26.730758 INFO Sending initial 'disconnected'.
2014/05/14 10:28:26.731273 DEBUG Invoking Info
2014/05/14 10:28:26.731521 DEBUG got initial state of Connected Global
2014/05/14 10:28:26.731570 ERROR got weird PrimaryConnection: 0x46
2014/05/14 10:28:26.731591 DEBUG primary connection starts as ""
2014/05/14 10:28:26.731603 DEBUG got state: Connected Global
2014/05/14 10:28:26.731621 ERROR got weird PropertiesChanged: 0x46
2014/05/14 10:28:26.731630 DEBUG State changed to Connected Global. Assuming disconnect.
2014/05/14 10:28:26.731721 DEBUG May be connected; checking...
2014/05/14 10:28:26.732217 INFO Connectivity check passed.
2014/05/14 10:28:26.732259 DEBUG Connection check says: true
2014/05/14 10:28:26.732277 INFO Sending 'connected'.
OOPS: 80 passed, 2 skipped, 2 FAILED
--- FAIL: TestClient (0.06 seconds)
FAIL
FAIL launchpad.net/ubuntu-push/client 0.069s
ok launchpad.net/ubuntu-push/client/gethosts 0.710s

----------------------------------------------------------------------
FAIL: service_test.go:42: serviceSuite.TestStart

service_test.go:45:
    c.Check(svc.Start(), IsNil)
... value *errors.errorString = &errors.errorString{s:"Unknown address type"} ("Unknown address type")

service_test.go:46:
    c.Check(svc.IsRunning(), Equals, true)
... obtained bool = false
... expected bool = true

----------------------------------------------------------------------
FAIL: service_test.go:62: serviceSuite.TestStartConnectsBus

service_test.go:64:
    c.Check(svc.Start(), IsNil)
... value *errors.errorString = &errors.errorString{s:"Unknown address type"} ("Unknown address type")

----------------------------------------------------------------------
FAIL: service_test.go:50: serviceSuite.TestStartTwice

service_test.go:52:
    c.Check(svc.Start(), IsNil)
... value *errors.errorString = &errors.errorString{s:"Unknown address type"} ("Unknown address type")

service_test.go:53:
    c.Check(svc.Start(), Equals, AlreadyStarted)
... obtained *errors.errorString = &errors.errorString{s:"Unknown address type"} ("Unknown address type")
... expected *errors.errorString = &errors.errorString{s:"already started"} ("already started")

OOPS: 5 passed, 3 FAILED
--- FAIL: TestService (0.01 seconds)
FAIL
FAIL launchpad.net/ubuntu-push/client/service 0.023s
ok launchpad.net/ubuntu-push/client/session 0.184s
ok launchpad.net/ubuntu-push/client/session/levelmap 0.070s
ok launchpad.net/ubuntu-push/config 0.010s
ok launchpad.net/ubuntu-push/external/murmur3 0.004s
ok launchpad.net/ubuntu-push/logger 0.008s
ok launchpad.net/ubuntu-push/protocol 0.010s
ok launchpad.net/ubuntu-push/server 0.041s
ok launchpad.net/ubuntu-push/server/api 0.018s
ok launchpad.net/ubuntu-push/server/broker 0.010s
ok launchpad.net/ubuntu-push/server/broker/simple 0.017s
? launchpad.net/ubuntu-push/server/broker/testing [no test files]
? launchpad.net/ubuntu-push/server/broker/testsuite [no test files]
? launchpad.net/ubuntu-push/server/dev [no test files]
ok launchpad.net/ubuntu-push/server/listener 0.374s
ok launchpad.net/ubuntu-push/server/session 0.185s
ok launchpad.net/ubuntu-push/server/store 0.210s
? launchpad.net/ubuntu-push/testing [no test files]
ok launchpad.net/ubuntu-push/testing/condition 0.004s
ok launchpad.net/ubuntu-push/util 0.006s
? launchpad.net/ubuntu-push/whoopsie [no test files]
ok launchpad.net/ubuntu-push/whoopsie/identifier 1.811s
ok launchpad.net/ubuntu-push/whoopsie/identifier/testing 0.008s

make: *** [check] Error 1