Ubuntu Push Notifications

Code review comment for lp:~chipaca/ubuntu-push/remove-handleconnstate

  1. remove-handleconnstate
  2. Merge into automatic
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~chipaca/ubuntu-push/remove-handleconnstate into lp:ubuntu-push/automatic failed. Below is the output from the failed tests.

scripts/deps.sh ubuntu-push-client.go
scripts/deps.sh server/dev/server.go
scripts/deps.sh server/acceptance/cmd/acceptanceclient.go
/mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin/godeps -t launchpad.net/ubuntu-push launchpad.net/ubuntu-push/accounts launchpad.net/ubuntu-push/bus launchpad.net/ubuntu-push/bus/accounts launchpad.net/ubuntu-push/bus/connectivity launchpad.net/ubuntu-push/bus/emblemcounter launchpad.net/ubuntu-push/bus/haptic launchpad.net/ubuntu-push/bus/networkmanager launchpad.net/ubuntu-push/bus/notifications launchpad.net/ubuntu-push/bus/polld launchpad.net/ubuntu-push/bus/powerd launchpad.net/ubuntu-push/bus/systemimage launchpad.net/ubuntu-push/bus/testing launchpad.net/ubuntu-push/bus/unitygreeter launchpad.net/ubuntu-push/bus/windowstack launchpad.net/ubuntu-push/click launchpad.net/ubuntu-push/click/cappinfo launchpad.net/ubuntu-push/click/cblacklist launchpad.net/ubuntu-push/click/cclick launchpad.net/ubuntu-push/click/testing launchpad.net/ubuntu-push/client launchpad.net/ubuntu-push/client/gethosts launchpad.net/ubuntu-push/client/service launchpad.net/ubuntu-push/client/session launchpad.net/ubuntu-push/client/session/seenstate launchpad.net/ubuntu-push/config launchpad.net/ubuntu-push/external/murmur3 launchpad.net/ubuntu-push/identifier launchpad.net/ubuntu-push/identifier/testing launchpad.net/ubuntu-push/launch_helper launchpad.net/ubuntu-push/launch_helper/cual launchpad.net/ubuntu-push/launch_helper/helper_finder launchpad.net/ubuntu-push/launch_helper/legacy launchpad.net/ubuntu-push/logger launchpad.net/ubuntu-push/messaging launchpad.net/ubuntu-push/messaging/cmessaging launchpad.net/ubuntu-push/messaging/reply launchpad.net/ubuntu-push/nih launchpad.net/ubuntu-push/nih/cnih launchpad.net/ubuntu-push/poller launchpad.net/ubuntu-push/protocol launchpad.net/ubuntu-push/server launchpad.net/ubuntu-push/server/api launchpad.net/ubuntu-push/server/broker launchpad.net/ubuntu-push/server/broker/simple launchpad.net/ubuntu-push/server/broker/testing launchpad.net/ubuntu-push/server/broker/testsuite launchpad.net/ubuntu-push/server/dev launchpad.net/ubuntu-push/server/listener launchpad.net/ubuntu-push/server/session launchpad.net/ubuntu-push/server/store launchpad.net/ubuntu-push/sounds launchpad.net/ubuntu-push/testing launchpad.net/ubuntu-push/testing/condition launchpad.net/ubuntu-push/urldispatcher launchpad.net/ubuntu-push/urldispatcher/curldispatcher launchpad.net/ubuntu-push/util launchpad.net/ubuntu-push/server/acceptance/cmd/ launchpad.net/ubuntu-push/server/dev/ launchpad.net/ubuntu-push/ 2>/dev/null | cat > dependencies.tsv
rm -f -r /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/pkg
mkdir -p /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin
mkdir -p /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/pkg
go get -u launchpad.net/godeps
go get -d -u launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3 code.google.com/p/go-uuid/uuid
/mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin/godeps -u dependencies.tsv
go install launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3 code.google.com/p/go-uuid/uuid
./scripts/goctest launchpad.net/ubuntu-push launchpad.net/ubuntu-push/accounts launchpad.net/ubuntu-push/bus launchpad.net/ubuntu-push/bus/accounts launchpad.net/ubuntu-push/bus/connectivity launchpad.net/ubuntu-push/bus/emblemcounter launchpad.net/ubuntu-push/bus/haptic launchpad.net/ubuntu-push/bus/networkmanager launchpad.net/ubuntu-push/bus/notifications launchpad.net/ubuntu-push/bus/polld launchpad.net/ubuntu-push/bus/powerd launchpad.net/ubuntu-push/bus/systemimage launchpad.net/ubuntu-push/bus/testing launchpad.net/ubuntu-push/bus/unitygreeter launchpad.net/ubuntu-push/bus/windowstack launchpad.net/ubuntu-push/click launchpad.net/ubuntu-push/click/cappinfo launchpad.net/ubuntu-push/click/cblacklist launchpad.net/ubuntu-push/click/cclick launchpad.net/ubuntu-push/click/testing launchpad.net/ubuntu-push/client launchpad.net/ubuntu-push/client/gethosts launchpad.net/ubuntu-push/client/service launchpad.net/ubuntu-push/client/session launchpad.net/ubuntu-push/client/session/seenstate launchpad.net/ubuntu-push/config launchpad.net/ubuntu-push/external/murmur3 launchpad.net/ubuntu-push/identifier launchpad.net/ubuntu-push/identifier/testing launchpad.net/ubuntu-push/launch_helper launchpad.net/ubuntu-push/launch_helper/cual launchpad.net/ubuntu-push/launch_helper/helper_finder launchpad.net/ubuntu-push/launch_helper/legacy launchpad.net/ubuntu-push/logger launchpad.net/ubuntu-push/messaging launchpad.net/ubuntu-push/messaging/cmessaging launchpad.net/ubuntu-push/messaging/reply launchpad.net/ubuntu-push/nih launchpad.net/ubuntu-push/nih/cnih launchpad.net/ubuntu-push/poller launchpad.net/ubuntu-push/protocol launchpad.net/ubuntu-push/server launchpad.net/ubuntu-push/server/api launchpad.net/ubuntu-push/server/broker launchpad.net/ubuntu-push/server/broker/simple launchpad.net/ubuntu-push/server/broker/testing launchpad.net/ubuntu-push/server/broker/testsuite launchpad.net/ubuntu-push/server/dev launchpad.net/ubuntu-push/server/listener launchpad.net/ubuntu-push/server/session launchpad.net/ubuntu-push/server/store launchpad.net/ubuntu-push/sounds launchpad.net/ubuntu-push/testing launchpad.net/ubuntu-push/testing/condition launchpad.net/ubuntu-push/urldispatcher launchpad.net/ubuntu-push/urldispatcher/curldispatcher launchpad.net/ubuntu-push/util
? launchpad.net/ubuntu-push [no test files]
? launchpad.net/ubuntu-push/accounts [no test files]
ok launchpad.net/ubuntu-push/bus 0.025s
ok launchpad.net/ubuntu-push/bus/accounts 0.035s
ok launchpad.net/ubuntu-push/bus/connectivity 1.152s
ok launchpad.net/ubuntu-push/bus/emblemcounter 0.077s
ok launchpad.net/ubuntu-push/bus/haptic 0.031s
ok launchpad.net/ubuntu-push/bus/networkmanager 0.106s
ok launchpad.net/ubuntu-push/bus/notifications 0.538s
ok launchpad.net/ubuntu-push/bus/polld 0.027s
ok launchpad.net/ubuntu-push/bus/powerd 0.039s
ok launchpad.net/ubuntu-push/bus/systemimage 0.025s
ok launchpad.net/ubuntu-push/bus/testing 0.024s
? launchpad.net/ubuntu-push/bus/unitygreeter [no test files]
ok launchpad.net/ubuntu-push/bus/windowstack 0.022s
ok launchpad.net/ubuntu-push/click 0.009s
? launchpad.net/ubuntu-push/click/cappinfo [no test files]
? launchpad.net/ubuntu-push/click/cblacklist [no test files]
? launchpad.net/ubuntu-push/click/cclick [no test files]
? launchpad.net/ubuntu-push/click/testing [no test files]
ok launchpad.net/ubuntu-push/client 3.686s
ok launchpad.net/ubuntu-push/client/gethosts 0.709s
ok launchpad.net/ubuntu-push/client/service 0.160s
ok launchpad.net/ubuntu-push/client/session 0.707s
ok launchpad.net/ubuntu-push/client/session/seenstate 10.503s
ok launchpad.net/ubuntu-push/config 0.009s
ok launchpad.net/ubuntu-push/external/murmur3 0.005s
ok launchpad.net/ubuntu-push/identifier 0.006s
ok launchpad.net/ubuntu-push/identifier/testing 0.005s

----------------------------------------------------------------------
FAIL: kindpool_test.go:218: poolSuite.TestRunCantLaunch

[LOG] 0:00.000 DEBUG using helper com.example.test_test-app-helper (exec: bar) for app com.example.test_test-app
[LOG] 0:00.000 ERROR unable to launch helper com.example.test_test-app-helper: can't launch helper
kindpool_test.go:233:
    res := takeNext(ch, c)
kindpool_test.go:49:
    c.Fatal("timeout waiting for result")
... Error: timeout waiting for result

WARNING: Error cleaning up temporaries: remove /tmp/gocheck-8674665223082153551: directory not emptyOOPS: 33 passed, 1 FAILED
--- FAIL: Test (3.23 seconds)
FAIL
FAIL launchpad.net/ubuntu-push/launch_helper 3.483s
? launchpad.net/ubuntu-push/launch_helper/cual [no test files]
ok launchpad.net/ubuntu-push/launch_helper/helper_finder 0.042s
ok launchpad.net/ubuntu-push/launch_helper/legacy 1.428s
ok launchpad.net/ubuntu-push/logger 0.012s
ok launchpad.net/ubuntu-push/messaging 0.025s
? launchpad.net/ubuntu-push/messaging/cmessaging [no test files]
? launchpad.net/ubuntu-push/messaging/reply [no test files]
ok launchpad.net/ubuntu-push/nih 0.005s
? launchpad.net/ubuntu-push/nih/cnih [no test files]
ok launchpad.net/ubuntu-push/poller 0.022s
ok launchpad.net/ubuntu-push/protocol 0.013s
ok launchpad.net/ubuntu-push/server 0.217s
ok launchpad.net/ubuntu-push/server/api 0.035s
ok launchpad.net/ubuntu-push/server/broker 0.027s
ok launchpad.net/ubuntu-push/server/broker/simple 0.020s
? launchpad.net/ubuntu-push/server/broker/testing [no test files]
? launchpad.net/ubuntu-push/server/broker/testsuite [no test files]
? launchpad.net/ubuntu-push/server/dev [no test files]
ok launchpad.net/ubuntu-push/server/listener 2.244s
ok launchpad.net/ubuntu-push/server/session 0.341s
ok launchpad.net/ubuntu-push/server/store 0.020s
ok launchpad.net/ubuntu-push/sounds 0.046s
? launchpad.net/ubuntu-push/testing [no test files]
ok launchpad.net/ubuntu-push/testing/condition 0.004s
ok launchpad.net/ubuntu-push/urldispatcher 0.023s
? launchpad.net/ubuntu-push/urldispatcher/curldispatcher [no test files]
ok launchpad.net/ubuntu-push/util 0.008s

Makefile:61: server/acceptance/cmd/acceptanceclient.go.deps: No such file or directory
Makefile:61: server/dev/server.go.deps: No such file or directory
Makefile:61: ubuntu-push-client.go.deps: No such file or directory
make: *** [check] Error 1

« Back to merge proposal