Ubuntu Push Notifications

Code review comment for lp:~chipaca/ubuntu-push/relativize-sounds

  1. relativize-sounds
  2. Merge into automatic
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~chipaca/ubuntu-push/relativize-sounds into lp:ubuntu-push/automatic failed. Below is the output from the failed tests.

scripts/deps.sh ubuntu-push-client.go
scripts/deps.sh server/dev/server.go
scripts/deps.sh server/acceptance/cmd/acceptanceclient.go
/mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin/godeps -t launchpad.net/ubuntu-push launchpad.net/ubuntu-push/accounts launchpad.net/ubuntu-push/bus launchpad.net/ubuntu-push/bus/accounts launchpad.net/ubuntu-push/bus/connectivity launchpad.net/ubuntu-push/bus/emblemcounter launchpad.net/ubuntu-push/bus/haptic launchpad.net/ubuntu-push/bus/networkmanager launchpad.net/ubuntu-push/bus/notifications launchpad.net/ubuntu-push/bus/polld launchpad.net/ubuntu-push/bus/powerd launchpad.net/ubuntu-push/bus/systemimage launchpad.net/ubuntu-push/bus/testing launchpad.net/ubuntu-push/bus/unitygreeter launchpad.net/ubuntu-push/bus/windowstack launchpad.net/ubuntu-push/click launchpad.net/ubuntu-push/click/cappinfo launchpad.net/ubuntu-push/click/cblacklist launchpad.net/ubuntu-push/click/cclick launchpad.net/ubuntu-push/click/testing launchpad.net/ubuntu-push/client launchpad.net/ubuntu-push/client/gethosts launchpad.net/ubuntu-push/client/service launchpad.net/ubuntu-push/client/session launchpad.net/ubuntu-push/client/session/seenstate launchpad.net/ubuntu-push/config launchpad.net/ubuntu-push/external/murmur3 launchpad.net/ubuntu-push/identifier launchpad.net/ubuntu-push/identifier/testing launchpad.net/ubuntu-push/launch_helper launchpad.net/ubuntu-push/launch_helper/cual launchpad.net/ubuntu-push/launch_helper/helper_finder launchpad.net/ubuntu-push/launch_helper/legacy launchpad.net/ubuntu-push/logger launchpad.net/ubuntu-push/messaging launchpad.net/ubuntu-push/messaging/cmessaging launchpad.net/ubuntu-push/messaging/reply launchpad.net/ubuntu-push/nih launchpad.net/ubuntu-push/nih/cnih launchpad.net/ubuntu-push/poller launchpad.net/ubuntu-push/protocol launchpad.net/ubuntu-push/server launchpad.net/ubuntu-push/server/api launchpad.net/ubuntu-push/server/broker launchpad.net/ubuntu-push/server/broker/simple launchpad.net/ubuntu-push/server/broker/testing launchpad.net/ubuntu-push/server/broker/testsuite launchpad.net/ubuntu-push/server/dev launchpad.net/ubuntu-push/server/listener launchpad.net/ubuntu-push/server/session launchpad.net/ubuntu-push/server/store launchpad.net/ubuntu-push/sounds launchpad.net/ubuntu-push/testing launchpad.net/ubuntu-push/testing/condition launchpad.net/ubuntu-push/urldispatcher launchpad.net/ubuntu-push/urldispatcher/curldispatcher launchpad.net/ubuntu-push/util launchpad.net/ubuntu-push/server/acceptance/cmd/ launchpad.net/ubuntu-push/server/dev/ launchpad.net/ubuntu-push/ 2>/dev/null | cat > dependencies.tsv
rm -f -r /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/pkg
mkdir -p /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin
mkdir -p /mnt/tarmac/cache/ubuntu-push-automatic/go-ws/pkg
go get -u launchpad.net/godeps
go get -d -u launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3 code.google.com/p/go-uuid/uuid
/mnt/tarmac/cache/ubuntu-push-automatic/go-ws/bin/godeps -u dependencies.tsv
code.google.com/p/go-uuid now at 7dda39b2e7d5e265014674c5af696ba4186679e9
launchpad.net/go-dbus/v1 now at <email address hidden>
go install launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3 code.google.com/p/go-uuid/uuid
./scripts/goctest launchpad.net/ubuntu-push launchpad.net/ubuntu-push/accounts launchpad.net/ubuntu-push/bus launchpad.net/ubuntu-push/bus/accounts launchpad.net/ubuntu-push/bus/connectivity launchpad.net/ubuntu-push/bus/emblemcounter launchpad.net/ubuntu-push/bus/haptic launchpad.net/ubuntu-push/bus/networkmanager launchpad.net/ubuntu-push/bus/notifications launchpad.net/ubuntu-push/bus/polld launchpad.net/ubuntu-push/bus/powerd launchpad.net/ubuntu-push/bus/systemimage launchpad.net/ubuntu-push/bus/testing launchpad.net/ubuntu-push/bus/unitygreeter launchpad.net/ubuntu-push/bus/windowstack launchpad.net/ubuntu-push/click launchpad.net/ubuntu-push/click/cappinfo launchpad.net/ubuntu-push/click/cblacklist launchpad.net/ubuntu-push/click/cclick launchpad.net/ubuntu-push/click/testing launchpad.net/ubuntu-push/client launchpad.net/ubuntu-push/client/gethosts launchpad.net/ubuntu-push/client/service launchpad.net/ubuntu-push/client/session launchpad.net/ubuntu-push/client/session/seenstate launchpad.net/ubuntu-push/config launchpad.net/ubuntu-push/external/murmur3 launchpad.net/ubuntu-push/identifier launchpad.net/ubuntu-push/identifier/testing launchpad.net/ubuntu-push/launch_helper launchpad.net/ubuntu-push/launch_helper/cual launchpad.net/ubuntu-push/launch_helper/helper_finder launchpad.net/ubuntu-push/launch_helper/legacy launchpad.net/ubuntu-push/logger launchpad.net/ubuntu-push/messaging launchpad.net/ubuntu-push/messaging/cmessaging launchpad.net/ubuntu-push/messaging/reply launchpad.net/ubuntu-push/nih launchpad.net/ubuntu-push/nih/cnih launchpad.net/ubuntu-push/poller launchpad.net/ubuntu-push/protocol launchpad.net/ubuntu-push/server launchpad.net/ubuntu-push/server/api launchpad.net/ubuntu-push/server/broker launchpad.net/ubuntu-push/server/broker/simple launchpad.net/ubuntu-push/server/broker/testing launchpad.net/ubuntu-push/server/broker/testsuite launchpad.net/ubuntu-push/server/dev launchpad.net/ubuntu-push/server/listener launchpad.net/ubuntu-push/server/session launchpad.net/ubuntu-push/server/store launchpad.net/ubuntu-push/sounds launchpad.net/ubuntu-push/testing launchpad.net/ubuntu-push/testing/condition launchpad.net/ubuntu-push/urldispatcher launchpad.net/ubuntu-push/urldispatcher/curldispatcher launchpad.net/ubuntu-push/util
? launchpad.net/ubuntu-push [no test files]
? launchpad.net/ubuntu-push/accounts [no test files]
ok launchpad.net/ubuntu-push/bus 0.025s

----------------------------------------------------------------------
FAIL: accounts_test.go:167: AccSuite.TestUpdateMessageSoundPrunesXDG

accounts_test.go:170:
    c.Check(a.messageSound, Equals, "xyzzy")
... obtained string = "/xyzzy"
... expected string = "xyzzy"

OOPS: 19 passed, 1 FAILED
--- FAIL: TestAcc (0.00 seconds)
FAIL
FAIL launchpad.net/ubuntu-push/bus/accounts 0.029s
ok launchpad.net/ubuntu-push/bus/connectivity 1.182s
ok launchpad.net/ubuntu-push/bus/emblemcounter 0.051s
ok launchpad.net/ubuntu-push/bus/haptic 0.033s
ok launchpad.net/ubuntu-push/bus/networkmanager 0.114s
ok launchpad.net/ubuntu-push/bus/notifications 0.545s
ok launchpad.net/ubuntu-push/bus/polld 0.042s
ok launchpad.net/ubuntu-push/bus/powerd 0.035s
ok launchpad.net/ubuntu-push/bus/systemimage 0.025s
ok launchpad.net/ubuntu-push/bus/testing 0.017s
? launchpad.net/ubuntu-push/bus/unitygreeter [no test files]
ok launchpad.net/ubuntu-push/bus/windowstack 0.025s
ok launchpad.net/ubuntu-push/click 0.011s
? launchpad.net/ubuntu-push/click/cappinfo [no test files]
? launchpad.net/ubuntu-push/click/cblacklist [no test files]
? launchpad.net/ubuntu-push/click/cclick [no test files]
? launchpad.net/ubuntu-push/click/testing [no test files]
ok launchpad.net/ubuntu-push/client 0.175s
ok launchpad.net/ubuntu-push/client/gethosts 0.713s
ok launchpad.net/ubuntu-push/client/service 0.079s
ok launchpad.net/ubuntu-push/client/session 0.100s
ok launchpad.net/ubuntu-push/client/session/seenstate 0.131s
ok launchpad.net/ubuntu-push/config 0.010s
ok launchpad.net/ubuntu-push/external/murmur3 0.004s
ok launchpad.net/ubuntu-push/identifier 0.005s
ok launchpad.net/ubuntu-push/identifier/testing 0.004s
ok launchpad.net/ubuntu-push/launch_helper 0.545s
? launchpad.net/ubuntu-push/launch_helper/cual [no test files]
ok launchpad.net/ubuntu-push/launch_helper/helper_finder 0.041s
ok launchpad.net/ubuntu-push/launch_helper/legacy 0.077s
ok launchpad.net/ubuntu-push/logger 0.011s
ok launchpad.net/ubuntu-push/messaging 0.035s
? launchpad.net/ubuntu-push/messaging/cmessaging [no test files]
? launchpad.net/ubuntu-push/messaging/reply [no test files]
ok launchpad.net/ubuntu-push/nih 0.012s
? launchpad.net/ubuntu-push/nih/cnih [no test files]
ok launchpad.net/ubuntu-push/poller 0.026s
ok launchpad.net/ubuntu-push/protocol 0.012s
ok launchpad.net/ubuntu-push/server 0.069s
ok launchpad.net/ubuntu-push/server/api 0.036s
ok launchpad.net/ubuntu-push/server/broker 0.032s
ok launchpad.net/ubuntu-push/server/broker/simple 0.026s
? launchpad.net/ubuntu-push/server/broker/testing [no test files]
? launchpad.net/ubuntu-push/server/broker/testsuite [no test files]
? launchpad.net/ubuntu-push/server/dev [no test files]
ok launchpad.net/ubuntu-push/server/listener 2.248s
ok launchpad.net/ubuntu-push/server/session 0.346s
ok launchpad.net/ubuntu-push/server/store 0.024s
ok launchpad.net/ubuntu-push/sounds 0.061s
? launchpad.net/ubuntu-push/testing [no test files]
ok launchpad.net/ubuntu-push/testing/condition 0.004s
ok launchpad.net/ubuntu-push/urldispatcher 0.039s
? launchpad.net/ubuntu-push/urldispatcher/curldispatcher [no test files]
ok launchpad.net/ubuntu-push/util 0.017s

Makefile:61: server/acceptance/cmd/acceptanceclient.go.deps: No such file or directory
Makefile:61: server/dev/server.go.deps: No such file or directory
Makefile:61: ubuntu-push-client.go.deps: No such file or directory
make: *** [check] Error 1

« Back to merge proposal