Merge lp:~chipaca/ubuntu-push/promises-schmromises into lp:ubuntu-push

Proposed by John Lenton
Status: Rejected
Rejected by: Samuele Pedroni
Proposed branch: lp:~chipaca/ubuntu-push/promises-schmromises
Merge into: lp:ubuntu-push
Diff against target: 61 lines (+13/-5)
3 files modified
debian/changelog (+8/-0)
launch_helper/kindpool_test.go (+3/-3)
signing-helper/CMakeLists.txt (+2/-2)
To merge this branch: bzr merge lp:~chipaca/ubuntu-push/promises-schmromises
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+266549@code.launchpad.net

Commit message

Tests pass with go 1.4 again.

Description of the change

Oooh, look. A fix because of a change to go that breaks the compatibility promise!

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-04-30 15:08:57 +0000
+++ debian/changelog 2015-07-31 14:51:33 +0000
@@ -1,3 +1,11 @@
1ubuntu-push (0.69-0ubuntu1) wily; urgency=medium
2
3 [ John R. Lenton ]
4 * go's compatibility promise fails us again; fixes for 1.4.
5 * fix gcc5-related linking issues.
6
7 -- John R. Lenton <john.lenton@canonical.com> Fri, 31 Jul 2015 13:52:04 +0100
8
1ubuntu-push (0.68+15.04.20150430.1-0ubuntu1) vivid; urgency=medium9ubuntu-push (0.68+15.04.20150430.1-0ubuntu1) vivid; urgency=medium
210
3 [ Samuele Pedroni ]11 [ Samuele Pedroni ]
412
=== modified file 'launch_helper/kindpool_test.go'
--- launch_helper/kindpool_test.go 2015-03-18 16:34:11 +0000
+++ launch_helper/kindpool_test.go 2015-07-31 14:51:33 +0000
@@ -278,7 +278,7 @@
278 args := HelperArgs{278 args := HelperArgs{
279 Input: input,279 Input: input,
280 FileOut: filepath.Join(d, "file_out.json"),280 FileOut: filepath.Join(d, "file_out.json"),
281 Timer: &time.Timer{},281 Timer: time.NewTimer(0),
282 }282 }
283 pool.hmap["l:1"] = &args283 pool.hmap["l:1"] = &args
284284
@@ -310,7 +310,7 @@
310 Payload: []byte(`"hello"`),310 Payload: []byte(`"hello"`),
311 },311 },
312 FileOut: "/does-not-exist",312 FileOut: "/does-not-exist",
313 Timer: &time.Timer{},313 Timer: time.NewTimer(0),
314 }314 }
315 pool.hmap["l:1"] = &args315 pool.hmap["l:1"] = &args
316316
@@ -337,7 +337,7 @@
337 NotificationId: "foo",337 NotificationId: "foo",
338 Payload: []byte(`"hello"`),338 Payload: []byte(`"hello"`),
339 },339 },
340 Timer: &time.Timer{},340 Timer: time.NewTimer(0),
341 }341 }
342 pool.hmap["l:1"] = &args342 pool.hmap["l:1"] = &args
343343
344344
=== modified file 'signing-helper/CMakeLists.txt'
--- signing-helper/CMakeLists.txt 2014-04-30 17:34:57 +0000
+++ signing-helper/CMakeLists.txt 2015-07-31 14:51:33 +0000
@@ -13,8 +13,8 @@
13SET (CMAKE_AUTOMOC ON)13SET (CMAKE_AUTOMOC ON)
14find_package(Qt5Core REQUIRED)14find_package(Qt5Core REQUIRED)
1515
16FILE (GLOB SIGNING_SOURCES signing*.cpp)16SET (SIGNING_SOURCES signing-helper.cpp)
17FILE (GLOB SIGNING_HEADERS signing*.h)17SET (SIGNING_HEADERS signing.h)
1818
19add_executable (${SIGNING_EXE}19add_executable (${SIGNING_EXE}
20 ${SIGNING_SOURCES}20 ${SIGNING_SOURCES}

Subscribers

People subscribed via source and target branches