Ubuntu Push Notifications

Code review comment for lp:~chipaca/ubuntu-push/prepersistance

  1. prepersistance
  2. Merge into trunk
Revision history for this message
John Lenton (chipaca) wrote :

Yes! yes, it should send a nack. Fixing.

The error path gets covered further down the pipeline, when there is a levelmap that can actually return non-nil error.

I use c.Assert on the error when I need to dereference the result (and in this case I don't). Otherwise I'd rather let it go ahead.

« Back to merge proposal