Code review comment for lp:~chipaca/ubuntu-push/elements-of-client-session-toponomy

Revision history for this message
Samuele Pedroni (pedronis) wrote :

42 + err = proto.ReadMessage(&connAck)

around here there should be a sanity check that connAck.Type is "connack"

114 + c.Check(err.Error(), Matches, ".*deadline.*")

gocheck has c.Check(err, ErrorMatches, ...)

I just noticed that upCh downCh are still from the point of view of the server, I suppose we need to live with that if we want to share later unless we can invent neutral names

« Back to merge proposal