Code review comment for lp:~chipaca/ubuntu-push/conflag-maybe

Revision history for this message
Samuele Pedroni (pedronis) wrote :

I was thinking of trying something similar at some point

in this form is mostly missing tests,

and I wonder if allowing for supplying things with the command line means it's ok if they are left out from the config? or it the idea that the config should have defaults?

doing the former needs two passes over the values though,

should the functionality be opt-in?

btw flag supports TimeDuration flags, wondering if it means there's a way not to have to turn ConfigTimeDuration in a Value

review: Needs Fixing

« Back to merge proposal