Code review comment for lp:~chipaca/ubuntu-push/complex-client-session

The attempt to merge lp:~chipaca/ubuntu-push/complex-client-session into lp:ubuntu-push failed. Below is the output from the failed tests.

mkdir -p /mnt/tarmac/cache/ubuntu-push/go-ws/bin
mkdir -p /mnt/tarmac/cache/ubuntu-push/go-ws/pkg
go get -u launchpad.net/godeps
go get -d -u launchpad.net/gocheck launchpad.net/go-dbus/v1
/mnt/tarmac/cache/ubuntu-push/go-ws/bin/godeps -u dependencies.tsv
"/mnt/tarmac/cache/ubuntu-push/go-ws/src/launchpad.net/gocheck" now at <email address hidden>
go install launchpad.net/gocheck launchpad.net/go-dbus/v1
go test launchpad.net/ubuntu-push/...
ok launchpad.net/ubuntu-push/bus 0.027s
ok launchpad.net/ubuntu-push/bus/connectivity 0.086s
ok launchpad.net/ubuntu-push/bus/networkmanager 0.065s
ok launchpad.net/ubuntu-push/bus/notifications 0.020s
ok launchpad.net/ubuntu-push/bus/testing 0.018s
ok launchpad.net/ubuntu-push/bus/urldispatcher 0.066s
ok launchpad.net/ubuntu-push/client/session 0.040s
ok launchpad.net/ubuntu-push/client/session/levelmap 0.005s
ok launchpad.net/ubuntu-push/config 0.009s
ok launchpad.net/ubuntu-push/logger 0.008s
ok launchpad.net/ubuntu-push/protocol 0.011s
ok launchpad.net/ubuntu-push/server 0.026s
ok launchpad.net/ubuntu-push/server/acceptance 0.008s
? launchpad.net/ubuntu-push/server/acceptance/cmd [no test files]
ok launchpad.net/ubuntu-push/server/api 0.035s
ok launchpad.net/ubuntu-push/server/broker 0.017s
ok launchpad.net/ubuntu-push/server/broker/simple 0.016s
? launchpad.net/ubuntu-push/server/broker/testing [no test files]
? launchpad.net/ubuntu-push/server/broker/testsuite [no test files]
? launchpad.net/ubuntu-push/server/dev [no test files]
ok launchpad.net/ubuntu-push/server/listener 0.497s

----------------------------------------------------------------------
FAIL: session_test.go:480: sessionSuite.TestSessionWire

session_test.go:511:
    c.Check(err, Equals, io.EOF)
... obtained *net.OpError = &net.OpError{Op:"read", Net:"tcp", Addr:(*net.TCPAddr)(0xc2100378a0), Err:(*net.timeoutError)(0x88f718)} ("read tcp 127.0.0.1:57857: i/o timeout")
... expected *errors.errorString = &errors.errorString{s:"EOF"} ("EOF")

session_test.go:514:
    // tracking
    c.Check(buf.String(), Matches, `.*connected.*\n.*registered DEV.*\n.*ended with: EOF\n`)
... value string = "" +
... "2014/01/31 14:57:34.417553 DEBUG session(7970372a523ef3) connected 127.0.0.1:57857\n" +
... "2014/01/31 14:57:34.417849 INFO session(7970372a523ef3) registered DEV\n" +
... "2014/01/31 14:57:34.430397 DEBUG session(7970372a523ef3) ended with: read tcp 127.0.0.1:57857: i/o timeout\n"
... regex string = ".*connected.*\\n.*registered DEV.*\\n.*ended with: EOF\\n"

OOPS: 22 passed, 1 FAILED
--- FAIL: TestSession (0.10 seconds)
FAIL
FAIL launchpad.net/ubuntu-push/server/session 0.131s
ok launchpad.net/ubuntu-push/server/store 0.019s
? launchpad.net/ubuntu-push/testing [no test files]
ok launchpad.net/ubuntu-push/testing/condition 0.009s
ok launchpad.net/ubuntu-push/util 0.052s
ok launchpad.net/ubuntu-push/whoopsie/identifier 0.018s
ok launchpad.net/ubuntu-push/whoopsie/identifier/testing 0.007s

make: *** [check] Error 1