Code review comment for lp:~chipaca/ubuntu-push/client-client-client

The attempt to merge lp:~chipaca/ubuntu-push/client-client-client into lp:ubuntu-push failed. Below is the output from the failed tests.

mkdir -p /mnt/tarmac/cache/ubuntu-push/go-ws/bin
mkdir -p /mnt/tarmac/cache/ubuntu-push/go-ws/pkg
go get -u launchpad.net/godeps
go get -d -u launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3
/mnt/tarmac/cache/ubuntu-push/go-ws/bin/godeps -u dependencies.tsv
"/mnt/tarmac/cache/ubuntu-push/go-ws/src/launchpad.net/gocheck" now at <email address hidden>
go install launchpad.net/gocheck launchpad.net/go-dbus/v1 launchpad.net/go-xdg/v0 code.google.com/p/gosqlite/sqlite3
go test launchpad.net/ubuntu-push/...
? launchpad.net/ubuntu-push [no test files]
ok launchpad.net/ubuntu-push/bus 0.009s
ok launchpad.net/ubuntu-push/bus/connectivity 0.148s
ok launchpad.net/ubuntu-push/bus/networkmanager 0.044s
ok launchpad.net/ubuntu-push/bus/notifications 0.016s
ok launchpad.net/ubuntu-push/bus/testing 0.017s
ok launchpad.net/ubuntu-push/bus/urldispatcher 0.010s
ok launchpad.net/ubuntu-push/client 0.071s
ok launchpad.net/ubuntu-push/client/session 0.091s
ok launchpad.net/ubuntu-push/client/session/levelmap 0.030s
ok launchpad.net/ubuntu-push/config 0.009s
ok launchpad.net/ubuntu-push/logger 0.008s
ok launchpad.net/ubuntu-push/protocol 0.010s
ok launchpad.net/ubuntu-push/server 0.044s
ok launchpad.net/ubuntu-push/server/acceptance 0.007s
? launchpad.net/ubuntu-push/server/acceptance/cmd [no test files]
? launchpad.net/ubuntu-push/server/acceptance/suites [no test files]
ok launchpad.net/ubuntu-push/server/api 0.021s
ok launchpad.net/ubuntu-push/server/broker 0.007s
ok launchpad.net/ubuntu-push/server/broker/simple 0.008s
? launchpad.net/ubuntu-push/server/broker/testing [no test files]
? launchpad.net/ubuntu-push/server/broker/testsuite [no test files]
? launchpad.net/ubuntu-push/server/dev [no test files]
ok launchpad.net/ubuntu-push/server/listener 0.376s
ok launchpad.net/ubuntu-push/server/session 0.159s
ok launchpad.net/ubuntu-push/server/store 0.207s
? launchpad.net/ubuntu-push/testing [no test files]
ok launchpad.net/ubuntu-push/testing/condition 0.004s
ok launchpad.net/ubuntu-push/util 0.012s
? launchpad.net/ubuntu-push/whoopsie [no test files]
ok launchpad.net/ubuntu-push/whoopsie/identifier 0.013s
ok launchpad.net/ubuntu-push/whoopsie/identifier/testing 0.018s
go test -race launchpad.net/ubuntu-push/...
? launchpad.net/ubuntu-push [no test files]
ok launchpad.net/ubuntu-push/bus 1.024s
ok launchpad.net/ubuntu-push/bus/connectivity 1.209s
ok launchpad.net/ubuntu-push/bus/networkmanager 1.059s
ok launchpad.net/ubuntu-push/bus/notifications 1.062s
ok launchpad.net/ubuntu-push/bus/testing 1.034s
ok launchpad.net/ubuntu-push/bus/urldispatcher 1.013s
ok launchpad.net/ubuntu-push/client 1.295s

----------------------------------------------------------------------
FAIL: session_test.go:785: clientSessionSuite.TestDialWorks

[LOG] 36.85478 ERROR unable to start: write version: read tcp 127.0.0.1:39058: i/o timeout
session_test.go:823:
    c.Assert(err, IsNil)
... value *net.OpError = &net.OpError{Op:"read", Net:"tcp", Addr:(*net.TCPAddr)(0xc2100c81b0), Err:(*net.timeoutError)(0xd78ef0)} ("read tcp 127.0.0.1:34412: i/o timeout")

----------------------------------------------------------------------
FAIL: session.go:1: clientSqlevelsSessionSuite.TestDialWorks

session.go:1:
[LOG] 36.85478 ERROR unable to start: write version: read tcp 127.0.0.1:46806: i/o timeout
    ...
session_test.go:823:
    c.Assert(err, IsNil)
... value *net.OpError = &net.OpError{Op:"read", Net:"tcp", Addr:(*net.TCPAddr)(0xc210107d80), Err:(*net.timeoutError)(0xd78ef0)} ("read tcp 127.0.0.1:58794: i/o timeout")

OOPS: 62 passed, 2 FAILED
--- FAIL: TestSession (1.11 seconds)
FAIL
FAIL launchpad.net/ubuntu-push/client/session 1.142s
ok launchpad.net/ubuntu-push/client/session/levelmap 1.107s
ok launchpad.net/ubuntu-push/config 1.066s
ok launchpad.net/ubuntu-push/logger 1.050s
ok launchpad.net/ubuntu-push/protocol 1.081s
ok launchpad.net/ubuntu-push/server 1.419s
ok launchpad.net/ubuntu-push/server/acceptance 1.038s
? launchpad.net/ubuntu-push/server/acceptance/cmd [no test files]
? launchpad.net/ubuntu-push/server/acceptance/suites [no test files]
ok launchpad.net/ubuntu-push/server/api 1.075s
ok launchpad.net/ubuntu-push/server/broker 1.033s
ok launchpad.net/ubuntu-push/server/broker/simple 1.051s
? launchpad.net/ubuntu-push/server/broker/testing [no test files]
? launchpad.net/ubuntu-push/server/broker/testsuite [no test files]
? launchpad.net/ubuntu-push/server/dev [no test files]
ok launchpad.net/ubuntu-push/server/listener 2.178s
ok launchpad.net/ubuntu-push/server/session 1.266s
ok launchpad.net/ubuntu-push/server/store 1.221s
? launchpad.net/ubuntu-push/testing [no test files]
ok launchpad.net/ubuntu-push/testing/condition 1.013s
ok launchpad.net/ubuntu-push/util 1.017s
? launchpad.net/ubuntu-push/whoopsie [no test files]
ok launchpad.net/ubuntu-push/whoopsie/identifier 1.015s
ok launchpad.net/ubuntu-push/whoopsie/identifier/testing 1.016s

make: *** [check-race] Error 1