Ubuntu Push Notifications

Code review comment for lp:~chipaca/ubuntu-push/chamera-orchestra

  1. chamera-orchestra
  2. Merge into trunk
Revision history for this message
Samuele Pedroni (pedronis) wrote :

203 + aCh <- notifications.RawActionReply{}

couldn't this be closed to the actual check? like the rest?

219 + // sessionConnectedCh to nothing in particular, but it'll help sync this test
220 + cli.sessionConnectedCh <- 42
221 + cli.sessionConnectedCh <- 42 // we check things one loop later (loopy, i know)

these comments didn't help me understand that cli.sessionConnectedCh sending is used to assure that we went through the full preceding loop

« Back to merge proposal