Code review comment for lp:~chipaca/snappy/copyfile

Revision history for this message
Michael Vogt (mvo) wrote :

This looks very nice, thanks for doing this!

META: It seems this is a good time to branch trunk into trunk and 15.04. This branch should go to trunk and I think we want to do fixes for 15.04 as well (but this branch looks more like trunk/devel material to me).

Some comments/questions inline. I really like that this branch removes duplicated code and moves in into a single well tested (and speedy!) place.

« Back to merge proposal