Snappy

Code review comment for lp:~chipaca/snappy/atomic-follow-symlinks

  1. atomic-follow-symlinks
  2. Merge into snappy-moved-to-github
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~chipaca/snappy/atomic-follow-symlinks into lp:snappy failed. Below is the output from the failed tests.

Checking docs
Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update github.com/gorilla/mux failed; trying to fetch newer version
update github.com/mvo5/goconfigparser failed; trying to fetch newer version
github.com/gorilla/mux now at ee1815431e497d3850809578c93ab6705f1a19f7
update github.com/cheggaaa/pb failed; trying to fetch newer version
github.com/mvo5/goconfigparser now at 26426272dda20cc76aa1fa44286dc743d2972fe8
update github.com/mvo5/uboot-go failed; trying to fetch newer version
github.com/cheggaaa/pb now at e8c7cc515bfde3e267957a3b110080ceed51354e
update gopkg.in/check.v1 failed; trying to fetch newer version
github.com/mvo5/uboot-go now at 361f6ebcbb54f389d15dc9faefa000e996ba3e37
update github.com/gosexy/gettext failed; trying to fetch newer version
gopkg.in/check.v1 now at 64131543e7896d5bcc6bd5a76287eb75ea96c673
update github.com/peterh/liner failed; trying to fetch newer version
github.com/gosexy/gettext now at 98b7b91596d20b96909e6b60d57411547dd9959c
update gopkg.in/tomb.v2 failed; trying to fetch newer version
github.com/peterh/liner now at 1bb0d1c1a25ed393d8feb09bab039b2b1b1fbced
update code.google.com/p/go.crypto failed; trying to fetch newer version
gopkg.in/tomb.v2 now at 14b3d72120e8d10ea6e6b7f87f7175734b1faab8
update github.com/blakesmith/ar failed; trying to fetch newer version
code.google.com/p/go.crypto now at 69e2a90ed92d03812364aeb947b7068dc42e561e
update github.com/coreos/go-systemd failed; trying to fetch newer version
github.com/blakesmith/ar now at c9a977dd0cc1392b023382c7bfa5a22af8d3b730
update github.com/gorilla/context failed; trying to fetch newer version
github.com/coreos/go-systemd now at f743bc15d6bddd23662280b4ad20f7c874cdd5ad
update github.com/jessevdk/go-flags failed; trying to fetch newer version
github.com/gorilla/context now at 1c83b3eabd45b6d76072b66b746c20815fb2872d
update golang.org/x/crypto failed; trying to fetch newer version
github.com/jessevdk/go-flags now at 1acbbaff2f347c412a0c7884873bd72cc9c1f5b4
update gopkg.in/yaml.v2 failed; trying to fetch newer version
golang.org/x/crypto now at 60052bd85f2d91293457e8811b0cf26b773de469
gopkg.in/yaml.v2 now at 49c95bdc21843256fb6c4e0d370a05f24a0bf213
Building
Running tests from /tmp/tmp.YRgRWPKpsg/src/launchpad.net/snappy
? launchpad.net/snappy/cmd/snapd [no test files]
=== RUN Test
OK: 12 passed
--- PASS: Test (0.04 seconds)
PASS
coverage: 21.2% of statements
ok launchpad.net/snappy/cmd/snappy 0.051s coverage: 21.2% of statements
=== RUN Test
OK: 53 passed
--- PASS: Test (0.35 seconds)
PASS
coverage: 91.7% of statements
ok launchpad.net/snappy/coreconfig 0.352s coverage: 91.7% of statements
=== RUN Test
OK: 39 passed
--- PASS: Test (0.16 seconds)
PASS
coverage: 69.8% of statements
ok launchpad.net/snappy/daemon 0.172s coverage: 69.8% of statements
? launchpad.net/snappy/dirs [no test files]
=== RUN Test
OK: 64 passed
--- PASS: Test (0.36 seconds)
PASS
coverage: 79.2% of statements
ok launchpad.net/snappy/helpers 0.371s coverage: 79.2% of statements
=== RUN Test
OK: 0 passed, 2 skipped
--- PASS: Test (0.01 seconds)
PASS
coverage: 33.3% of statements
ok launchpad.net/snappy/i18n 0.013s coverage: 33.3% of statements
=== RUN Test
OK: 16 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 92.6% of statements
ok launchpad.net/snappy/i18n/xgettext-go 0.023s coverage: 92.6% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 93.5% of statements
ok launchpad.net/snappy/logger 0.008s coverage: 93.5% of statements
=== RUN Test
OK: 4 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/oauth 0.005s coverage: 100.0% of statements
=== RUN Test
OK: 42 passed
--- PASS: Test (0.46 seconds)
PASS
coverage: 74.7% of statements
ok launchpad.net/snappy/partition 0.464s coverage: 74.7% of statements
=== RUN Test
OK: 3 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/pkg 0.004s coverage: 100.0% of statements
=== RUN Test
OK: 18 passed
--- PASS: Test (0.30 seconds)
PASS
coverage: 74.4% of statements
ok launchpad.net/snappy/pkg/clickdeb 0.309s coverage: 74.4% of statements
=== RUN Test
OK: 20 passed
--- PASS: Test (0.07 seconds)
=== RUN: ExamplePartBag
--- PASS: ExamplePartBag (8.427771ms)
PASS
coverage: 93.5% of statements
ok launchpad.net/snappy/pkg/lightweight 0.088s coverage: 93.5% of statements
? launchpad.net/snappy/pkg/remote [no test files]
=== RUN Test
OK: 3 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 94.4% of statements
ok launchpad.net/snappy/pkg/removed 0.010s coverage: 94.4% of statements
=== RUN Test
OK: 10 passed
--- PASS: Test (0.08 seconds)
PASS
coverage: 70.0% of statements
ok launchpad.net/snappy/pkg/snapfs 0.098s coverage: 70.0% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.11 seconds)
PASS
coverage: 94.3% of statements
ok launchpad.net/snappy/policy 0.124s coverage: 94.3% of statements
=== RUN Test
OK: 5 passed
--- PASS: Test (0.20 seconds)
PASS
coverage: 91.1% of statements
ok launchpad.net/snappy/priv 0.209s coverage: 91.1% of statements
=== RUN Test
OK: 4 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 50.0% of statements
ok launchpad.net/snappy/progress 0.027s coverage: 50.0% of statements
=== RUN Test
OK: 9 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 96.4% of statements
ok launchpad.net/snappy/provisioning 0.011s coverage: 96.4% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 95.0% of statements
ok launchpad.net/snappy/release 0.007s coverage: 95.0% of statements
=== RUN Test
bin/foo
meta/package.yaml
.click/info/hello-app.origin.manifest

----------------------------------------------------------------------
FAIL: click_test.go:1661: SnapTestSuite.TestWriteCompatManifestJSONNoFollow

click_test.go:1674:
    c.Check(helpers.FileExists(symlinkTarget), Equals, false)
... obtained bool = true
... expected bool = false

OOPS: 305 passed, 1 FAILED
--- FAIL: Test (11.47 seconds)
FAIL
FAIL launchpad.net/snappy/snappy 11.485s
=== RUN Test
OK: 20 passed
--- PASS: Test (0.52 seconds)
PASS
coverage: 74.0% of statements
ok launchpad.net/snappy/systemd 0.532s coverage: 74.0% of statements

Crushing failure and despair.

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/snappy
cp -a . $GOPATH/src/launchpad.net/snappy/
cd $GOPATH/src/launchpad.net/snappy

sh -v ./run-checks
#!/bin/sh

set -eu

if which goctest >/dev/null; then
    goctest="goctest"
else
    goctest="go test"
fi

QUICK=""
if [ "${1:-}" = "--quick" ]; then
    QUICK=yes
fi

endmsg() {
    if [ $? -eq 0 ]; then
        p="success.txt"
        m="All good, what could possibly go wrong."
    else
        p="failure.txt"
        m="Crushing failure and despair."
    fi
    echo
    if [ -t 1 -a -z "$QUICK" ]; then
        cat "data/$p"
    else
        echo "$m"
    fi
}
trap endmsg EXIT

echo Checking docs
./mdlint.py docs/*.md

echo Checking formatting
fmt=$(gofmt -l .)

if [ -n "$fmt" ]; then
    echo "Formatting wrong in following files"
    echo "$fmt"
    exit 1
fi

if [ -z "$QUICK" ]; then
    echo Installing godeps
    go get launchpad.net/godeps
    export PATH=$PATH:$GOPATH/bin

    echo Install golint
    go get github.com/golang/lint/golint
    export PATH=$PATH:$GOPATH/bin

    echo Obtaining dependencies
    godeps -u dependencies.tsv

    echo Building
    go build -v launchpad.net/snappy/...

    # tests
    echo Running tests from $(pwd)
    $goctest -v -cover ./...
fi
github.com/coreos/go-systemd/activation
github.com/gorilla/context
gopkg.in/tomb.v2
github.com/gorilla/mux
launchpad.net/snappy/dirs
launchpad.net/snappy/logger
launchpad.net/snappy/helpers
launchpad.net/snappy/pkg
gopkg.in/yaml.v2
launchpad.net/snappy/pkg/remote
github.com/cheggaaa/pb
launchpad.net/snappy/progress
github.com/mvo5/goconfigparser
launchpad.net/snappy/coreconfig
github.com/gosexy/gettext
launchpad.net/snappy/oauth
github.com/mvo5/uboot-go/uenv
launchpad.net/snappy/partition
launchpad.net/snappy/i18n
github.com/blakesmith/ar
launchpad.net/snappy/pkg/clickdeb
launchpad.net/snappy/pkg/snapfs
launchpad.net/snappy/policy
launchpad.net/snappy/provisioning
launchpad.net/snappy/release
launchpad.net/snappy/systemd
code.google.com/p/go.crypto/ssh/terminal
github.com/jessevdk/go-flags
launchpad.net/snappy/snappy
github.com/peterh/liner
launchpad.net/snappy/priv
launchpad.net/snappy/i18n/xgettext-go
launchpad.net/snappy/pkg/removed
launchpad.net/snappy/pkg/lightweight
launchpad.net/snappy/daemon
launchpad.net/snappy/cmd/snapd
launchpad.net/snappy/cmd/snappy

« Back to merge proposal