Code review comment for lp:~chipaca/snap-confine/unshare

Revision history for this message
John Lenton (chipaca) wrote :

Thank you for the review!
Fixed the missing /tmp/ (d'oh), moved the chown (good idea! added a comment so we remember why), done the changes to the apparmor profile.

I suspect the cleanest way to go about clenaing up /tmp/ is to have something like tmpreaper, but we haven't really discussed it yet.

« Back to merge proposal