Code review comment for lp:~chillycreator/drizzle/drizzle-fix

Revision history for this message
Stewart Smith (stewart) wrote :

I don't think this especially makes this bit of code easier to read/understand.

create_tmp_table() as a lot of problems, and the gotos aren't anywhere near the top.

the name error_return() is also too generic for a very specific error handling method.

that being said, the code does actually look correct, so good work on that!

review: Disapprove

« Back to merge proposal