Code review comment for plainbox-provider-checkbox:fix-audio-test-get-source-sink-ids

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Hello Yao,

I tested on KRPL-SFF-DVT-C1_202208-30552, it will show
ubuntu@ubuntu:~$ pactl get-default-sink
alsa_output.pci-0000_00_1f.3.analog-stereo
ubuntu@ubuntu:~$ pactl get-default-source
alsa_output.pci-0000_00_1f.3.analog-stereo.monitor

The original logic seems filter out monitor.
Will it impact the result if you just return the output of $ pactl get-default-{sink,source}?

Thanks,

« Back to merge proposal