Merge ~checkbox-dev/checkbox/+git/support:release_deb_jenkins_credentials into ~checkbox-dev/checkbox/+git/support:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 9e2e0261551852f63097c76c03fd10f6dba591b4
Merged at revision: 5b13f015944ebc9b2e5043e8d563c72080ff2042
Proposed branch: ~checkbox-dev/checkbox/+git/support:release_deb_jenkins_credentials
Merge into: ~checkbox-dev/checkbox/+git/support:master
Diff against target: 34 lines (+4/-4)
1 file modified
release/git/release_deb.py (+4/-4)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Review via email: mp+411518@code.launchpad.net

Description of the change

Use credentials binding for checkbox deb release pipeline

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/release/git/release_deb.py b/release/git/release_deb.py
2index a7481f6..1f2210b 100755
3--- a/release/git/release_deb.py
4+++ b/release/git/release_deb.py
5@@ -447,7 +447,7 @@ class Release():
6 self.base_url, self.target_user, self.project),
7 '--delete', 'release'], cwd=self.clone_dir)
8 else:
9- output = run("./support/release/git/lp-propose-merge ~{}/{} -s --merged-timeout 3600 --credentials $HOME/.hwcert_creds/credentials".format(self.target_user, self.project), shell=True, check=True).stdout.decode()
10+ output = run("./support/release/git/lp-propose-merge ~{}/{} -s --merged-timeout 3600 --credentials $LP_CREDS".format(self.target_user, self.project), shell=True, check=True).stdout.decode()
11 logger.info(output)
12 # Delete the release branch once merged into master
13 run(['git', 'push', '{}/~{}/{}'.format(
14@@ -468,11 +468,11 @@ class Release():
15 else:
16 if self.config['mode'] == 'testing':
17 output = run(
18- "./support/release/git/lp-recipe-update-build {} --recipe {} -n {} --credentials $HOME/.hwcert_creds/credentials".format(
19+ "./support/release/git/lp-recipe-update-build {} --recipe {} -n {} --credentials $LP_CREDS".format(
20 self.project, self.project+'-testing', new_version), shell=True, check=True).stdout.decode().rstrip()
21 else:
22 output = run(
23- "./support/release/git/lp-recipe-update-build {} --recipe {} -n {} --credentials $HOME/.hwcert_creds/credentials".format(
24+ "./support/release/git/lp-recipe-update-build {} --recipe {} -n {} --credentials $LP_CREDS".format(
25 self.project, self.project+'-stable', new_version), shell=True, check=True).stdout.decode().rstrip()
26 logger.info(output)
27
28@@ -488,7 +488,7 @@ class Release():
29 logger.info('# Dry run: Skipping {} {} milestone step'.format(
30 self.project, new_version))
31 else:
32- output = run("./support/release/git/lp-release-milestone {} -m {} --credentials $HOME/.hwcert_creds/credentials".format(self.project, new_version), shell=True, check=True).stdout.decode()
33+ output = run("./support/release/git/lp-release-milestone {} -m {} --credentials $LP_CREDS".format(self.project, new_version), shell=True, check=True).stdout.decode()
34 logger.info(output)
35
36

Subscribers

People subscribed via source and target branches

to all changes: