Code review comment for lp:~chasedouglas/grail/touch-states

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

* some changes merely fix indentation. That pollutes the commit diff and bzr history.
* touch.h and touch.cpp headers should have a 2012 copyright and should be LGPL.
* I don't like the cyclic reference "Touch <-> Recognizer" even though Touch doesn't hold a shared_ptr of Recognizer. I think it would be cleaner to pass device and window_id to Touch instead of the recognizer himself. As for the Recognizer::DeleteTouch() call, since recognizer holds weak pointers things are still under control. When querying all_touches_ you would just have to also check whether the content is null and if so remove it from the list. Can we use sigc++ or some library that provides signals and slots? That would be the best solution.

« Back to merge proposal