Grail

Code review comment for lp:~chasedouglas/grail/rework

  1. rework
  2. Merge into trunk
Revision history for this message
Stephen M. Webb (bregma) wrote :

I've been using this branch for geis development and testing, so I give it a general approval except for the following.

(1) The test suite gets built with a 'make all' target, which is not usual procedure. The Makefile.am in the test subdirectory should use a check_PROGRAMS target and not a noinst_PROGRAMS target.

(2) There is no way to disable building the test suite if xorg-gtest is installed on your system, and the test suite fails to build if the --with-xi argument is not given to ./configure.

(3) The TwoDrag test fails throwing a "Failed to open device file" exception. It looks like the test data is missing from the repo.

review: Needs Fixing

« Back to merge proposal