Light Display Manager

Code review comment for lp:~charlesk/lightdm/lp-1235915

  1. lp-1235915
  2. Merge into trunk
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Is there a particular bug this is fixing? Looking at the xklavier source xkl_engine_get_instance should always return an object except in the case where display is NULL (which should probably be a g_assert).

Perhaps the correct fix here is to check if XOpenDisplay is NULL instead?

« Back to merge proposal