Code review comment for lp:~charlesk/libdbusmenu/lp-1083399

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Tests would fail a different way (with tests uncommented as Ted suggests):

make[4]: Leaving directory `/«PKGBUILDDIR»/builddir/gtk2/tests'
make[3]: Leaving directory `/«PKGBUILDDIR»/builddir/gtk2/tests'
Making check in docs
make[3]: Entering directory `/«PKGBUILDDIR»/builddir/gtk2/docs'
Making check in libdbusmenu-glib
make[4]: Entering directory `/«PKGBUILDDIR»/builddir/gtk2/docs/libdbusmenu-glib'
Making check in reference
make[5]: Entering directory `/«PKGBUILDDIR»/builddir/gtk2/docs/libdbusmenu-glib/reference'
make check-TESTS
make[6]: Entering directory `/«PKGBUILDDIR»/builddir/gtk2/docs/libdbusmenu-glib/reference'
Running suite(s): gtk-doc-libdbusmenu-glib
libdbusmenu-glib-undocumented.txt:1:E: 139 undocumented or incomplete symbols
/«PKGBUILDDIR»/builddir/gtk2/docs/libdbusmenu-glib/reference/libdbusmenu-glib-undeclared.txt:1:E: 129 undeclared symbols
50.0%: Checks 4, Failures: 2
FAIL: /usr/bin/gtkdoc-check
==================================
1 of 1 test failed
Please report to <email address hidden>
==================================

review: Needs Fixing

« Back to merge proposal