Code review comment for lp:~charlesk/indicator-datetime/make-gcc-version-explicit

Revision history for this message
Charles Kerr (charlesk) wrote :

In IRC, Thomas said that he marked as "Needs Fixing" because of either the gcc string or because of the (missing) dh_auto_configure line... the gcc string looks the same as in the reference version at <https://wiki.ubuntu.com/cpp-11>, and I don't believe we need an override_dh_auto_configure rule here because exporting CC and CXX as environment variables is enough for cmake to pick them up.

So, I'm not sure what needs to be fixed here...

« Back to merge proposal