Indicator Date and Time

Merge lp:~charlesk/indicator-datetime/lp-1370594-refresh-notifications-to-match-design into lp:indicator-datetime/13.10

  1. lp-1370594-refresh-notifications-to-match-design
  2. Merge into trunk.14.10
Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 380
Merged at revision: 381
Proposed branch: lp:~charlesk/indicator-datetime/lp-1370594-refresh-notifications-to-match-design
Merge into: lp:indicator-datetime/13.10
Diff against target: 43 lines (+6/-5)
3 files modified
include/notifications/notifications.h (+3/-2)
src/notifications.cpp (+1/-1)
src/snap.cpp (+2/-2)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/lp-1370594-refresh-notifications-to-match-design
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan (community) Approve
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+235025@code.launchpad.net

Commit message

Make alarm notifications icons and button color match Design's specs.

Description of the change

== Description of the Change

 1. Use the new affirmative-tint hint to color the "OK" button.

 2. Work around unity-notifications bug #1370641 to remove the border around the notification's icon.

I.e., the green button coloring and icon now match design: https://i.imgur.com/Y8SHGnw.png

== Checklist

> Are there any related MPs required for this MP to build/function as expected? Please list.

No

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> What device (or emulator) has your component test plan been executed successfully on?

mako + RTM r46

> What manual tests are relevant for this MP?

Run any of the manual tests that involves creating an alarm; e.g. indicator-datetime/snooze, and confirm that the notification's icon and button color look like https://i.imgur.com/Y8SHGnw.png

> Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?

https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-datetime

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:380
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/280/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-utopic-amd64-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-utopic-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-utopic-armhf-ci/54/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/280/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Tested on Mako Image 244 and works nicely!

review: Approve
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Please let me confirm with designer tomorrow morning regarding the new visual.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'include/notifications/notifications.h'
--- include/notifications/notifications.h 2014-07-30 22:59:52 +0000
+++ include/notifications/notifications.h 2014-09-17 17:58:35 +0000
@@ -59,8 +59,9 @@
59 These keys may be dependent on the notification server. */59 These keys may be dependent on the notification server. */
60 void add_hint (const std::string& name);60 void add_hint (const std::string& name);
61 static constexpr char const * HINT_SNAP {"x-canonical-snap-decisions"};61 static constexpr char const * HINT_SNAP {"x-canonical-snap-decisions"};
62 static constexpr char const * HINT_TINT {"x-canonical-private-button-tint"};62 static constexpr char const * HINT_NONSHAPED_ICON {"x-canonical-non-shaped-icon"};
63 static constexpr char const * HINT_NONSHAPEDICON {"x-canonical-non-shaped-icon"};63 static constexpr char const * HINT_AFFIRMATIVE_HINT {"x-canonical-private-affirmative-tint"};
64 static constexpr char const * HINT_REJECTION_TINT {"x-canonical-private-rejection-tint"};
6465
65 /* Add an action button.66 /* Add an action button.
66 This may fail if the Engine doesn't support actions.67 This may fail if the Engine doesn't support actions.
6768
=== modified file 'src/notifications.cpp'
--- src/notifications.cpp 2014-08-08 20:31:49 +0000
+++ src/notifications.cpp 2014-09-17 17:58:35 +0000
@@ -198,7 +198,7 @@
198 {198 {
199 notify_notification_set_hint (nn.get(),199 notify_notification_set_hint (nn.get(),
200 hint.c_str(),200 hint.c_str(),
201 g_variant_new_boolean(true));201 g_variant_new_string("true"));
202 }202 }
203203
204 for (const auto& action : info.m_actions)204 for (const auto& action : info.m_actions)
205205
=== modified file 'src/snap.cpp'
--- src/snap.cpp 2014-09-15 14:56:29 +0000
+++ src/snap.cpp 2014-09-17 17:58:35 +0000
@@ -91,8 +91,8 @@
91 b.set_body (appointment.summary);91 b.set_body (appointment.summary);
92 b.set_icon_name ("alarm-clock");92 b.set_icon_name ("alarm-clock");
93 b.add_hint (uin::Builder::HINT_SNAP);93 b.add_hint (uin::Builder::HINT_SNAP);
94 b.add_hint (uin::Builder::HINT_TINT);94 b.add_hint (uin::Builder::HINT_AFFIRMATIVE_HINT);
95 b.add_hint (uin::Builder::HINT_NONSHAPEDICON);95 b.add_hint (uin::Builder::HINT_NONSHAPED_ICON);
9696
97 const char * timefmt;97 const char * timefmt;
98 if (is_locale_12h()) {98 if (is_locale_12h()) {

Subscribers

People subscribed via source and target branches