Code review comment for lp:~charlesk/indicator-datetime/lp-1283142

I agree with Seb, we should check for the capabilities instead of the server's name.

Why did you remove stop_alarm_sound() from the action callbacks? According to the spec[1], a server doesn't have to send CloseNotification in that case. notify-osd seems to to so, though.

show_notification() handles stopping of sound when the bubble type is snap decision, but not starting the sound. That's decided in notify(). It might make sense to put these together somehow.

I think having sound on the desktop would make a lot of sense as well. Is it gone because there's no easy way to dismiss it without buttons on notifications?

[1] https://developer.gnome.org/notification-spec/