Code review comment for lp:~charlesk/indicator-datetime/lp-1283142

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Charles! Looks fine to me but I've one small question

> is_notify_osd = !g_strcmp0(name, "notify-osd");

is special casing notify-osd really the right thing to do there? would it make more sense to use notify_get_server_caps() instead?

review: Needs Information

« Back to merge proposal