Code review comment for lp:~charlesk/indicator-datetime/lp-1074999

Revision history for this message
Lars Karlitski (larsu) wrote :

Nice cleanup!

`geo_master` doesn't need to be a global variable: it's only ever used in geo_start.

Why are you calling geo_stop unconditionally in on_use_geoclue_changed? I'd put it in the `else` below, in case the callback is called even though the value hasn't changed (which may happen according to the docs).

review: Needs Fixing

« Back to merge proposal