Code review comment for lp:~charlesk/indicator-datetime/cmakeify

Revision history for this message
Pete Woods (pete-woods) wrote :

The cmake stuff all looks pretty reasonable to me. The one thing I'd change is the GETTEXT_PACKAGE variable. It messes up the dh_translations script, which only does a trivial grep of the root CMakeLists.txt file. You'll have to explicitly put:

set (GETTEXT_PACKAGE "indicator-datetime")

« Back to merge proposal