Merge lp:~charlesk/indicator-appmenu/lp-957412 into lp:indicator-appmenu/0.4

Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 181
Merged at revision: 183
Proposed branch: lp:~charlesk/indicator-appmenu/lp-957412
Merge into: lp:indicator-appmenu/0.4
Diff against target: 21 lines (+2/-2)
1 file modified
src/indicator-appmenu.c (+2/-2)
To merge this branch: bzr merge lp:~charlesk/indicator-appmenu/lp-957412
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+98004@code.launchpad.net

Description of the change

The function's unused argument "path" was shadowed by a local variable. Fixed by renaming the argument to "object_path"

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/indicator-appmenu.c'
--- src/indicator-appmenu.c 2012-03-16 15:48:16 +0000
+++ src/indicator-appmenu.c 2012-03-16 22:00:32 +0000
@@ -184,7 +184,7 @@
184static gboolean retry_registration (gpointer user_data);184static gboolean retry_registration (gpointer user_data);
185static void bus_method_call (GDBusConnection * connection,185static void bus_method_call (GDBusConnection * connection,
186 const gchar * sender,186 const gchar * sender,
187 const gchar * path,187 const gchar * object_path,
188 const gchar * interface,188 const gchar * interface,
189 const gchar * method,189 const gchar * method,
190 GVariant * params,190 GVariant * params,
@@ -1282,7 +1282,7 @@
1282 is and dispatch it. */1282 is and dispatch it. */
1283static void1283static void
1284bus_method_call (GDBusConnection * connection, const gchar * sender,1284bus_method_call (GDBusConnection * connection, const gchar * sender,
1285 const gchar * path, const gchar * interface,1285 const gchar * object_path, const gchar * interface,
1286 const gchar * method, GVariant * params,1286 const gchar * method, GVariant * params,
1287 GDBusMethodInvocation * invocation, gpointer user_data)1287 GDBusMethodInvocation * invocation, gpointer user_data)
1288{1288{

Subscribers

People subscribed via source and target branches