Merge lp:~charlesk/indicator-application/lp-1197788 into lp:indicator-application/14.04

Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 241
Merged at revision: 241
Proposed branch: lp:~charlesk/indicator-application/lp-1197788
Merge into: lp:indicator-application/14.04
Diff against target: 21 lines (+3/-1)
1 file modified
src/application-service-watcher.c (+3/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-application/lp-1197788
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+192368@code.launchpad.net

Description of the change

When we can't get a handle to the system bus, exit gracefully instead of crashing.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Thank you.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Looks like a Jenkins hiccup. Starting a new pass.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/application-service-watcher.c'
--- src/application-service-watcher.c 2012-12-18 19:08:50 +0000
+++ src/application-service-watcher.c 2013-10-23 17:07:09 +0000
@@ -24,6 +24,7 @@
24#include "config.h"24#include "config.h"
25#endif25#endif
2626
27#include <stdlib.h>
27#include <dbus/dbus-glib.h>28#include <dbus/dbus-glib.h>
28#include <dbus/dbus-glib-lowlevel.h>29#include <dbus/dbus-glib-lowlevel.h>
29#include <dbus/dbus-glib-bindings.h>30#include <dbus/dbus-glib-bindings.h>
@@ -158,8 +159,9 @@
158 GError * error = NULL;159 GError * error = NULL;
159 DBusGConnection * session_bus = dbus_g_bus_get(DBUS_BUS_SESSION, &error);160 DBusGConnection * session_bus = dbus_g_bus_get(DBUS_BUS_SESSION, &error);
160 if (error != NULL) {161 if (error != NULL) {
161 g_error("Unable to get session bus: %s", error->message);162 g_warning("Unable to get session bus: %s", error->message);
162 g_error_free(error);163 g_error_free(error);
164 exit(0);
163 return;165 return;
164 }166 }
165167

Subscribers

People subscribed via source and target branches