Code review comment for lp:~charlesk/gnome-bluetooth/indicators

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that looks better, small minor comments,questions though:

> ++ else if ((gsettings != NULL) && !g_settings_get_boolean (gsettings, GSETTINGS_VISIBLE_KEY))

the NULL checking is not needed there, g_settings_new() can't return null, it works or the install is broken it exits

> g_clear_object (&self->priv->indicator_settings);

shouldn't g_object_unref() be used rather there?

> ++++ b/applet/com.canonical.indicator.bluetooth.gschema.xml

you should use a .xml.in with _summary and _description keys and list it in POTFILES.in to make the summary and description translatable and the .xml should be generated at build time

Otherwise the changes look good and seem to work fine, the checkbox seems a bit too close from the ui frame in the capplet though and maybe it would be better with some margin but I will let design comment on that

review: Needs Fixing

« Back to merge proposal