Code review comment for lp:~charles-wisniewski/sahana-agasti/0.6.4

Revision history for this message
charles wisniewski (charles-wisniewski) wrote :

Ah, hello...

The only difference is that it is now explicitly handled this way (i.e.
you do not have to manually specify &$variable, you can just pass
$variable to pass by reference) those were the only changes made and code
still executes just as should, though does not provide warnings now. it
was in response to tim/fran's want to show/use sahana-agasti as a proof of
concept

Charles Wisniewski
Application Architect
CUNY School of Professional Studies
tel: 212.652.2094
http://sps.cuny.edu/

chamindra <email address hidden>
Sent by: <email address hidden>
05/30/2010 09:05 AM
Please respond to
<email address hidden>

To
<email address hidden>
cc

Subject
Re: [Merge] lp:~charles-wisniewski/sahana-agasti/0.6.4 into
lp:sahana-agasti/0.6

Review: Needs Information
The pass by reference was probably implemented for a reason. It modified
the $conf directly. Does this impact the functions that use that
reference? And what is the alternative that has been implemented to
resolve it? A return with the new values?
--
https://code.launchpad.net/~charles-wisniewski/sahana-agasti/0.6.4/+merge/26250

You are the owner of lp:~charles-wisniewski/sahana-agasti/0.6.4.

« Back to merge proposal