Code review comment for lp:~charclo-michael/entertainer/small-fixes
Revision history for this message
| Paul Hummer (rockstar) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I made an attempt tonight to resolve conflicts with this branch and make the changes necessary. I didn't get very far.
Michael, the conflicts will probably be rather easy for you to resolve. My main concern is that there are A LOT of open 'except:' clauses. The branch cannot land with those. We found a lot of bugs when I went through and ripped those out that we wouldn't have found otherwise. In most cases, it looks like you'll be safe doing 'except KeyError:' Bugs can be introduced with open excepts, because you might be hiding cases where another exception is raised (like TypeError or ValueError) which MAY be a bug or may need to be handled differently.