Code review comment for ~chad.smith/ubuntu/+source/update-notifier:update-notifier-esm-support-hirsute

Revision history for this message
Bryce Harrington (bryce) wrote :

Since the xenial sru is under a deadline to get uploaded, and since the code docs aren't a necessary part of the fix, I went ahead and uploaded this branch as is, but do please incorporate them in your branch so they'll be there for the next update.

triage-hirsute+21.04:~/pkg/UpdateNotifier/review-mp401662/update-notifier-gu$ git ubuntu tag -f --upload
Updated tag 'upload/3.192.40.1' (was d633f7f)
triage-hirsute+21.04:~/pkg/UpdateNotifier/review-mp401662/update-notifier-gu$ git push pkg upload/3.192.40.1
Enumerating objects: 39, done.
Counting objects: 100% (39/39), done.
Delta compression using up to 12 threads
Compressing objects: 100% (19/19), done.
Writing objects: 100% (31/31), 8.71 KiB | 1.45 MiB/s, done.
Total 31 (delta 24), reused 16 (delta 12), pack-reused 0
To ssh://git.launchpad.net/ubuntu/+source/update-notifier
 * [new tag] upload/3.192.40.1 -> upload/3.192.40.1
triage-hirsute+21.04:~/pkg/UpdateNotifier/review-mp401662$ dput ubuntu update-notifier_3.192.40.1_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: /home/bryce/pkg/UpdateNotifier/review-mp401662/update-notifier_3.192.40.1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/pkg/UpdateNotifier/review-mp401662/update-notifier_3.192.40.1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading update-notifier_3.192.40.1.dsc: done.
  Uploading update-notifier_3.192.40.1.tar.xz: done.
  Uploading update-notifier_3.192.40.1_source.buildinfo: done.
  Uploading update-notifier_3.192.40.1_source.changes: done.
Successfully uploaded packages.

review: Approve

« Back to merge proposal