Ubuntu
needrestart package

Code review comment for ~chad.smith/ubuntu/+source/needrestart:lp-2059337-dont-autorestart-cloud-final

  1. Git
  2. lp:~chad.smith/ubuntu/+source/needrestart
  3. lp-2059337-dont-autorestart-cloud-final
  4. Merge into ubuntu/devel
Revision history for this message
Chad Smith (chad.smith) wrote :

Thanks Athos for the swift review here. I've fixed all comments you mentioned:

1. dep3 Description . on dep3 paragraph breaks
2. dep3 Author email format fix
3. dep3 dropped origin: other since we have author
4. dep3 Bug-Ubuntu instead of Bug:
5. quilt patch content: move the comment about bug LP: #2059337 closer to the cloud-init regex instead of adding the link to the generic upstream comment
6. dropped the stray .* from cloud-init regex. It was carried over from my earlier iteration of a more inclusive regex on cloud-.*.service. I decided on a 2nd pass that I needed to make it more strict to avoid matching any other unknown systemd services that started with the prefix `cloud-` and just limit it to cloud-init's 4 boot stage services: cloud-init-local.service, cloud-init.service, cloud-config.service and cloud-final.service.

« Back to merge proposal