Code review comment for ~chad.smith/cloud-init:ubuntu/xenial

Scott Moser (smoser) wrote :

c-i failed, so we need to update/refresh some quilt patches it looks like
though i'm confused by why that would fail but our daily artful be fine:
 https://code.launchpad.net/~cloud-init-dev/+recipe/cloud-init-daily-artful

anyway... the other thing from me typing in IRC:

21:38 <@smoser> blackboxsw: i would probably not add the new depends into x, a
21:39 <@smoser> it probably *is* strictly required.
21:39 <@smoser> but because isc-dhcp-client is part of ubuntu-minimal
21:40 <@smoser> and you're really expected to create a ubuntu without 'ubuntu-minimal'
21:40 <@smoser> it is not likely that cloud-init is to be installed in such a place.
21:43 <@smoser> so.. i'd just leave it be. additionally, adding depends or recommends like that to a stable can be problematic
21:43 <@smoser> see someone complaining about a similar add
21:43 <@smoser> https://bugs.launchpad.net/ubuntu/+source/initramfs-tools/+bug/1633643
21:43 <ubot5> Ubuntu bug 1633643 in initramfs-tools (Ubuntu) "unnecessary dependency upon isc-dhcp-client" [Undecided,Invalid]
21:44 <@smoser> and then also the squashfuse bug (bug 1628289)
21:44 <ubot5> bug 1628289 in Snappy "snapd should depend on squashfuse (for use in containers)" [Undecided,In progress] https://launchpad.net/bugs/1628289

« Back to merge proposal