Code review comment for ~chad.smith/cloud-init:simpletable-getstring-fix

Revision history for this message
Scott Moser (smoser) wrote :

need to make sure the failure there is just noise... looks like it was,
and doesn't seem like it should be related.

the code looks good and thanks for the tests.

I am running a test here just quick to verify we get
the network output rendered.

I ran a integration test with:
$ tox -e citest -- run --preserve-data --data-dir=/tmp/artifacts --deb=/home/smoser-public/src/cloud-init/build/../cloud-init_17.1-20-gdaf5dd11-1~bddeb_all.deb --verbose --os-name=xenial --test=modules/final_message

and then verify that /tmp/artifacts/lxd/xenial/modules/final_message/cloud-init-output.log had the
messages we wanted. see
 http://paste.ubuntu.com/25714903/

« Back to merge proposal