Code review comment for ~chad.smith/cloud-init:unify-datasource-get-data
Revision history for this message
| Ryan Harper (raharper) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
In commit message:
s/it's/its
I'd replace 'caches' metadata, to dumps; cache implies (to me) reuse but cloud-init doesn't use the json file at all (nor would it since it's already part of the cloud object).
Drop the 'Subsequent' sentence; while you may follow up with that it's not needed as part of the commit message.
Finally, question on the aborting if we have unserializable data; is it possible to skip/replace the binary data so we don't have an all-or-nothing situation?