Code review comment for ~chad.smith/cloud-init:cc-ntp-schema-validation

Revision history for this message
Scott Moser (smoser) wrote :

I like it very much.

Some comments inline. comments.
looking at diff i see that tools/cloudconfig-schema has some whitespace-end-of-line issues.

tools/cloudconfig-schema needs chmod +x.
tools/cloudconfig-schema: def error() should got to sys.stderr.write(message + "\n") ?
might as well write errors to stderr.

Overall this is wonderful. Thank you.

The jsonschema thing is the only sticking point. we can add a dependency to trunk
and trunk's package build. But I dont yet want to add a runtime dependency on it.
So somehow we have to address that.

« Back to merge proposal