Juju Charms Collection
storage package

Code review comment for lp:~chad.smith/charms/precise/storage/storage-volume-label-availability-zone

  1. Precise Pangolin (12.04)
  2. storage-volume-label-availability-zone
  3. Merge into trunk
Revision history for this message
Fernando Correa Neto (fcorrea) wrote :

Looks great! +1

[1]
71 + except subprocess.CalledProcessError, e:
72 + log("Error: couldn't discover ec2 availability zone. %s" % str(e),
73 + hookenv.ERROR)

Even though this block is for the ec2 try, it only indicates that it failed grabbing both nova and ec2, in which case I think we could log something more generic. Maybe "Error: couldn't discover volume availability zone..."

review: Approve

« Back to merge proposal