Code review comment for lp:~chad.smith/charms/precise/postgresql/postgresql-manual-tune-kernel-params-fix

Revision history for this message
Stuart Bishop (stub) wrote :

This all looks good. The cleanups are much needed, as are the retrofitted unittests. And those globals... thanks for killing some more of them.

The checks for "wal_buffers = -1" are unnecessary, as this setting is not related to replication.

review: Approve

« Back to merge proposal