Merge lp:~chad.smith/charms/precise/mysql/mysql-ha-with-health into lp:~openstack-charmers/charms/precise/mysql/ha-support

Proposed by Chad Smith
Status: Merged
Merged at revision: 106
Proposed branch: lp:~chad.smith/charms/precise/mysql/mysql-ha-with-health
Merge into: lp:~openstack-charmers/charms/precise/mysql/ha-support
Diff against target: 27 lines (+11/-0)
3 files modified
scripts/add_to_cluster (+2/-0)
scripts/health_checks.d/service_crm_access (+7/-0)
scripts/remove_from_cluster (+2/-0)
To merge this branch: bzr merge lp:~chad.smith/charms/precise/mysql/mysql-ha-with-health
Reviewer Review Type Date Requested Status
James Page Approve
Adam Gandelman Pending
Jerry Seutter Pending
Review via email: mp+155548@code.launchpad.net

This proposal supersedes a proposal from 2013-03-26.

Description of the change

Add mysql health checks and add_to_cluster/remove_from_cluster scripts to mysql/ha-support charm. Landscape-client uses these scripts during rolling OpenStack upgrades to make sure mysql services are alive and well and that the HA vips are migrated off the current node in the event of a reboot.

Comparable changes have gone into most of the other openstack services.

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote : Posted in a previous version of this proposal

We only have a very simplistic health_check in this branch because mysql service is actually completing inoperable on the passive unit due to the ceph shared rados filesystem being shifted to the active leader of the HA service. Without the filesystem, we can't validate that mysql is in good health until this unit cycles back to active leader.

Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory 'scripts'
=== added file 'scripts/add_to_cluster'
--- scripts/add_to_cluster 1970-01-01 00:00:00 +0000
+++ scripts/add_to_cluster 2013-03-26 16:22:51 +0000
@@ -0,0 +1,2 @@
1#!/bin/bash
2crm node online
03
=== added directory 'scripts/health_checks.d'
=== added file 'scripts/health_checks.d/service_crm_access'
--- scripts/health_checks.d/service_crm_access 1970-01-01 00:00:00 +0000
+++ scripts/health_checks.d/service_crm_access 2013-03-26 16:22:51 +0000
@@ -0,0 +1,7 @@
1#!/bin/bash -e
2# ensure this host is present in a CRM config and has access to crm tools.
3#
4# Since mysql service isn't running on the secondary/passive node, we have no
5# other easy means for determining the health of the mysql service until this
6# node becomes the active leader for the HA service.
7crm status 2>/dev/null | grep -q `hostname`
08
=== added file 'scripts/remove_from_cluster'
--- scripts/remove_from_cluster 1970-01-01 00:00:00 +0000
+++ scripts/remove_from_cluster 2013-03-26 16:22:51 +0000
@@ -0,0 +1,2 @@
1#!/bin/bash
2crm node standby

Subscribers

People subscribed via source and target branches