Juju Charms Collection
block-storage-broker package

Code review comment for lp:~chad.smith/charms/precise/block-storage-broker/bsb-retries-on-volume-create-and-attach

  1. Precise Pangolin (12.04)
  2. bsb-retries-on-volume-create-and-attach
  3. Merge into trunk
Revision history for this message
Chad Smith (chad.smith) wrote :

> [0] in _def_run_command(), why split the output into lines in a list? I think
> doing an rstrip() on the result would be enough..

The output was being split into lines to pre-enable a follow-on branch which would use _run_command for our "nova volume-show" calls. This volume-show has multi-line output and splitting it in the _run_command call would make parsing of that output a bit simpler. I'll pull it out of this branch though as nothing "currently" uses that functionality.

« Back to merge proposal