Code review comment for lp:~cgregan/checkbox/hybrid-graphics-screenshot

Revision history for this message
Daniel Manrique (roadmr) wrote :

OK, two more things.

The id for the attachment job is still weird, as it's identical to the screenshot job. I suspect the screenshot needs a .png at the end of the id.

Also, this won't work yet due to bug 1425722 which I discovered while testing this. A fix for that is proposed:

https://code.launchpad.net/~roadmr/checkbox/1425722-graphics-card-resource/+merge/251016

I'll mark this merge as depending on that one, but don't forget to commit the id fix :)

review: Needs Fixing

« Back to merge proposal