Code review comment for ~cgrabowski/maas:fix_connections_dict_update_while_updating_connection_count

Revision history for this message
Björn Tillenius (bjornt) wrote :

Ok. So I do think that we still have a problem. What can happen is that registerWorkerRPCConnection() registers a new connection in the database, but then update() works on the old "connections" dict and removes the connection from the database. Then after 60 seconds update() runs again with the new "connections" dict and adds it back.

Not sure if this causes any actual problems, though.

« Back to merge proposal