Code review comment for ~cgrabowski/maas:fix_connections_dict_update_while_updating_connection_count

Revision history for this message
Björn Tillenius (bjornt) wrote :

Your patch probably fixes the traceback. But I'd like to understand a bit what is actually modifying the dictionary?

I wonder if we have another problem here, and we're only fixing the symptoms. I did run the test you added, but that doesn't seem to trigger the problem.

review: Needs Information

« Back to merge proposal