Merge ~cgrabowski/maas:fix_connection_pool_handshake_race_condition into maas:master
Proposed by
Christian Grabowski
Status: | Merged |
---|---|
Approved by: | Christian Grabowski |
Approved revision: | cdc506149c60aeed840bf0dd951e41fdf0860a53 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~cgrabowski/maas:fix_connection_pool_handshake_race_condition |
Merge into: | maas:master |
Diff against target: |
154 lines (+64/-18) 4 files modified
src/provisioningserver/rpc/clusterservice.py (+1/-1) src/provisioningserver/rpc/connectionpool.py (+8/-8) src/provisioningserver/rpc/tests/test_clusterservice.py (+27/-6) src/provisioningserver/rpc/tests/test_connectionpool.py (+28/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
MAAS Lander | Approve | ||
Alexsander de Souza | Approve | ||
Review via email: mp+429170@code.launchpad.net |
Commit message
only allow the clusterservice to call add_connection to avoid race condition with rpc handshake
To post a comment you must log in.
UNIT TESTS pool_handshake_ race_condition lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas
-b fix_connection_
STATUS: FAILED maas-ci. internal: 8080/job/ maas-tester/ 439/consoleText f1b69b0cf0b0077 6f4571a666
LOG: http://
COMMIT: 3833aa2744122bf